Skip to content

IFilestore Api implemented #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

IFilestore Api implemented #37

wants to merge 5 commits into from

Conversation

amaid
Copy link

@amaid amaid commented Sep 1, 2024

No description provided.

@Arlodotexe
Copy link
Collaborator

Resolves #33

@Arlodotexe
Copy link
Collaborator

@amaid A minor few changes to make here and in ipfs-shipyard/net-ipfs-http-client#41

@Arlodotexe
Copy link
Collaborator

Arlodotexe commented Nov 16, 2024

@amaid I'd like to expand on what you have here to resolve #34. It should end up looking like:

image

Code pushes to follow!

@Arlodotexe
Copy link
Collaborator

This is a bit jank, it looks like the API doesn't return a proper JSON array of objects. It streams the objects line-by-line in the response. We'll have to handle this in the implementation, for now I'll just adjust to return IAsyncEnumerable.

image

@Arlodotexe
Copy link
Collaborator

We'll get this merged in as part of #41. Thanks again for your contributions here, it helped us get the ball rolling!

@Arlodotexe Arlodotexe closed this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants